Skip to content

Conversation

c-thiel
Copy link
Collaborator

@c-thiel c-thiel commented Sep 17, 2025

Which issue does this PR close?

Towards V3 Support!

What changes are included in this PR?

Introduce V3 FormatVersion accross Iceberg Metadata.

Are these changes tested?

Yes. Java has a few more tests regarding other table operations (different deletes, remove file), but we don't have those yet in our Transaction interface.

@kevinjqliu kevinjqliu self-requested a review September 17, 2025 18:44
Fokko
Fokko previously approved these changes Sep 23, 2025
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @c-thiel for picking this up 💪

@c-thiel
Copy link
Collaborator Author

c-thiel commented Sep 29, 2025

@Fokko I added a few more tests and fixed an optional in EncryptedKey. Ready for another round!

Maybe also @Xuanwo or @liurenjie1024 could check this?
By far most of the lines of code are tests - I hope the size is OK-ish :)

FIRST_ROW_ID.clone(),
REFERENCE_DATA_FILE.clone(),
// Why are the following two fields here in the existing v2 schema?
// In the spec, they are not even listed as optional for v2.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same doubt and this question also applies to the FIRST_ROW_ID above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants