-
Notifications
You must be signed in to change notification settings - Fork 331
feat: Support for V3 Metadata #1682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @c-thiel for picking this up 💪
Co-authored-by: Fokko Driesprong <[email protected]>
@Fokko I added a few more tests and fixed an optional in Maybe also @Xuanwo or @liurenjie1024 could check this? |
FIRST_ROW_ID.clone(), | ||
REFERENCE_DATA_FILE.clone(), | ||
// Why are the following two fields here in the existing v2 schema? | ||
// In the spec, they are not even listed as optional for v2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the same doubt and this question also applies to the FIRST_ROW_ID
above
Which issue does this PR close?
Towards V3 Support!
What changes are included in this PR?
Introduce V3 FormatVersion accross Iceberg Metadata.
Are these changes tested?
Yes. Java has a few more tests regarding other table operations (different deletes, remove file), but we don't have those yet in our Transaction interface.